Add check query integrity unit testing#26112
Draft
kevintang2022 wants to merge 3 commits intoprestodb:masterfrom
Draft
Add check query integrity unit testing#26112kevintang2022 wants to merge 3 commits intoprestodb:masterfrom
kevintang2022 wants to merge 3 commits intoprestodb:masterfrom
Conversation
Contributor
Reviewer's GuideThis PR adds support for denying query integrity checks via a new SystemAccessControl implementation and integrates it into the testing infrastructure, updating the TestingPrestoServer, DistributedQueryRunner, and AccessControlManager to configure and load custom access control settings, and includes a new unit test to verify query integrity enforcement. Class diagram for new and updated access control classesclassDiagram
class AccessControlManager {
+addSystemAccessControlFactory(SystemAccessControlFactory)
+loadSystemAccessControl()
}
class SystemAccessControlFactory {
<<interface>>
+getName()
+create(config)
}
class SystemAccessControl {
<<interface>>
+checkQueryIntegrity(...)
+checkCanSetUser(...)
+checkCanSetSystemSessionProperty(...)
+checkCanAccessCatalog(...)
+filterCatalogs(...)
+filterSchemas(...)
+checkCanCreateTable(...)
+checkCanShowCreateTable(...)
}
class DenyQueryIntegrityCheckSystemAccessControl {
+NAME
+Factory
+checkQueryIntegrity(...)
+checkCanSetUser(...)
+checkCanSetSystemSessionProperty(...)
+checkCanAccessCatalog(...)
+filterCatalogs(...)
+filterSchemas(...)
+checkCanCreateTable(...)
+checkCanShowCreateTable(...)
}
class TestingAccessControlManager {
+TestingAccessControlManager(TransactionManager, boolean)
}
AccessControlManager --> SystemAccessControlFactory
DenyQueryIntegrityCheckSystemAccessControl ..|> SystemAccessControl
DenyQueryIntegrityCheckSystemAccessControl : Factory
DenyQueryIntegrityCheckSystemAccessControl.Factory ..|> SystemAccessControlFactory
TestingAccessControlManager ..|> AccessControlManager
Class diagram for TestingPrestoServer and TestingPrestoServerModule changesclassDiagram
class TestingPrestoServer {
+TestingPrestoServer(..., boolean loadDefaultSystemAccessControl, ...)
}
class TestingPrestoServerModule {
+TestingPrestoServerModule(boolean)
+configure(Binder)
+createAccessControlManager(TransactionManager)
}
TestingPrestoServer --> TestingPrestoServerModule
Class diagram for new TestingPrestoServerModule bindingsclassDiagram
class TestingPrestoServerModule {
+configure(Binder)
+createAccessControlManager(TransactionManager)
}
class PrestoAuthenticatorManager
class TestingEventListenerManager
class TestingTempStorageManager
class EventListenerManager
class EventListenerConfig
class TempStorageManager
class AccessControl
class AccessControlManager
class GracefulShutdownHandler
class ProcedureTester
TestingPrestoServerModule --> PrestoAuthenticatorManager
TestingPrestoServerModule --> TestingEventListenerManager
TestingPrestoServerModule --> TestingTempStorageManager
TestingPrestoServerModule --> EventListenerManager
TestingPrestoServerModule --> EventListenerConfig
TestingPrestoServerModule --> TempStorageManager
TestingPrestoServerModule --> AccessControl
TestingPrestoServerModule --> AccessControlManager
TestingPrestoServerModule --> GracefulShutdownHandler
TestingPrestoServerModule --> ProcedureTester
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
56dc274 to
05be18b
Compare
05be18b to
b3b0669
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: